Skip to content

schema-python: land sprint/schema-python/py-retain-2 by hand - #4346

Merged
gafferongames merged 2 commits into
mainfrom
sprint/schema-python/py-retain-2
Nov 17, 2026
Merged

gafferongames merged 2 commits into
mainfrom
sprint/schema-python/py-retain-2

Conversation

@gafferongames

Copy link
Copy Markdown
Contributor

Landed by hand with nova-sprint land.

rowan-claude and others added 2 commits November 17, 2026 04:38
TestPythonRetainReadSurface drives test/conformance/python/surfaces/retain.py over every retain row of the shared manifest on both pinned interpreters and compares each answer with retain-values/<case>.json. Its negative control plants a retaining load that answers a default root in a copy of the generated unit and must go red on retain_round_trip by name. Both join python-retain-0 and the control row.

By: Rowan

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
port/python/vt/retain-unknown, tested at 3e7b56e: the retain tests and controls under SCHEMA_SLOW=1 on both pinned CPython interpreters.

By: Rowan

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@gafferongames
gafferongames merged commit 0ac9739 into main Nov 17, 2026
436 of 461 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants