Repository navigation
sdk-toolchain: SDK-IN-USE check, and SHARE-HELD below the top - #6451
Merged
Merged
Conversation
rowan-claude
added a commit
that referenced
this pull request
Nov 13, 2026
… top-level links, climbs past dangling ones; functional tests run both scripts Cold reader findings on #6451: /proc names resolved paths, so a home under a linked /home was missed; a top-level link pulled another version's tree into the comparison; a dangling link in the shared SDK hid what was below it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
rowan-claude
added a commit
that referenced
this pull request
Nov 13, 2026
…n themselves, skips a top-level dl, and takes names starting with a dash Second cold reader on #6451: a shared switch without lib hid every package below it, since the climb stopped there and the directory itself was never listed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…re SHARE-HELD below the top amd-1, 2026-11-13: the old ~/sdk was deleted while TLC's java ran from it, and a stable toolchain only the old rustup held was lost because SHARE-HELD compared the top level only. Now the run fails naming the processes (SDK-IN-USE) before the move and before the delete, and never stops them; SHARE-HELD compares two levels down and into rustup toolchains, cargo tools and opam packages. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
… top-level links, climbs past dangling ones; functional tests run both scripts Cold reader findings on #6451: /proc names resolved paths, so a home under a linked /home was missed; a top-level link pulled another version's tree into the comparison; a dangling link in the shared SDK hid what was below it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…n themselves, skips a top-level dl, and takes names starting with a dash Second cold reader on #6451: a shared switch without lib hid every package below it, since the climb stopped there and the directory itself was never listed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
gafferongames
force-pushed
the
fix/sdk-in-use-and-deeper-share-held
branch
from
November 17, 2026 13:29
d83863b to
ed68fc7
Compare
gafferongames
added a commit
that referenced
this pull request
Nov 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On amd-1 (2026-11-13), the shared-SDK switch deleted the old ~/sdk while TLC's java was running from it. The stable toolchain that only the old rustup held was also lost, because SHARE-HELD compared the top level only.
Testing:
This PR is not to be run on any host until it is released.
🤖 Generated with Claude Code