Skip to content

netcode: land sprint/netcode/nc-client-family-mismatch by hand - #219

Merged
gafferongames merged 6 commits into
mainfrom
sprint/netcode/nc-client-family-mismatch
Nov 10, 2026
Merged

gafferongames merged 6 commits into
mainfrom
sprint/netcode/nc-client-family-mismatch

Conversation

@gafferongames

Copy link
Copy Markdown
Contributor

Landed by hand with nova-sprint land.

rowan-claude and others added 6 commits November 10, 2026 00:19
netcode_client_connect and netcode_client_connect_to_next_server skip a
connect-token server address whose family has no client socket, unless a
network simulator or send/receive override is active. If connect finds
none, the client reports an invalid connect token. If none remain while
advancing, connect-to-next-server returns without moving, and the caller
ends the attempt the same way it does when no server is left.

test_client_connect_matching_address_family

By: Johnny Grok

Co-Authored-By: Johnny Grok <johnny@mas-bandwidth.com>
Descriptor 0 is a valid socket on main; the client's per-family check and
test_client_connect_matching_address_family now use
netcode_socket_handle_valid and NETCODE_SOCKET_HANDLE_INVALID instead of
comparing handles with 0.

By: Rowan

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add the IPv6-only mirror of the client address family selection test. A
token with only an IPv4 address leaves the client in the invalid connect
token state, and a token with an unusable IPv4 address followed by a
usable IPv6 address selects the IPv6 address.

Pump the server in test_server_update_drains_empty_datagrams until the
payload arrives, bounded by a timeout, so delayed datagrams do not make
the test flaky.

By: Rowan

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bring the card onto the latest base and keep both new client tests along
with the server address family selection coverage.

By: opencode
Co-Authored-By: opencode <noreply@opencode.ai>
@gafferongames
gafferongames merged commit 8aea1cd into main Nov 10, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants