Repository navigation
netcode: land sprint/netcode/nc-client-family-mismatch by hand - #219
Merged
Merged
Conversation
netcode_client_connect and netcode_client_connect_to_next_server skip a connect-token server address whose family has no client socket, unless a network simulator or send/receive override is active. If connect finds none, the client reports an invalid connect token. If none remain while advancing, connect-to-next-server returns without moving, and the caller ends the attempt the same way it does when no server is left. test_client_connect_matching_address_family By: Johnny Grok Co-Authored-By: Johnny Grok <johnny@mas-bandwidth.com>
…ent-family-mismatch
Descriptor 0 is a valid socket on main; the client's per-family check and test_client_connect_matching_address_family now use netcode_socket_handle_valid and NETCODE_SOCKET_HANDLE_INVALID instead of comparing handles with 0. By: Rowan Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Add the IPv6-only mirror of the client address family selection test. A token with only an IPv4 address leaves the client in the invalid connect token state, and a token with an unusable IPv4 address followed by a usable IPv6 address selects the IPv6 address. Pump the server in test_server_update_drains_empty_datagrams until the payload arrives, bounded by a timeout, so delayed datagrams do not make the test flaky. By: Rowan Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Bring the card onto the latest base and keep both new client tests along with the server address family selection coverage. By: opencode Co-Authored-By: opencode <noreply@opencode.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Landed by hand with nova-sprint land.