Repository navigation
netcode: land 1 card(s) - #213
Merged
Merged
Conversation
The start-floor comparison now rejects a connect token whose expire timestamp equals the floor. Add a boundary test for the equality case and adjust the valid-token test and conformance driver lifetimes so tokens generated in the server start second expire after the floor. By: Emma Antigravity Co-Authored-By: Emma Antigravity <emma@mas-bandwidth.com>
Pin the start-floor regression to the token's own expire timestamp rather than racing the wall clock, and cover acceptance one second above the floor. Keep issued token lifetimes within the server's configured maximum and model a later issuance second in the conformance drivers. By: OpenCode Co-Authored-By: OpenCode <opencode@anomaly.co>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened by nova-sprint's landing. sprint/netcode/nc-start-floor-same-second