Skip to content

Run the client/server socket tests only with --ignored - #68

Merged
rowan-claude merged 3 commits into
mainfrom
rowan/client-server-functional
Nov 10, 2026
Merged

rowan-claude merged 3 commits into
mainfrom
rowan/client-server-functional

Conversation

@rowan-claude

Copy link
Copy Markdown
Contributor

Every test in tests/client_server.rs binds real localhost UDP sockets and sleeps between updates, so they are functional tests. This marks each of the 13 with #[ignore = "functional: binds a real UDP socket; run with --ignored"] (the pattern from #66), so a plain cargo test binds no socket and does not sleep.

A new functional CI job runs cargo test --test client_server -- --ignored on Linux, macOS and Windows, in parallel with the other jobs, so the coverage the test matrix had stays in CI.

Verified on Linux x86_64: cargo test passes with client_server 13 ignored; cargo test --test client_server -- --ignored passes 13/13; cargo clippy --all-targets -- -D warnings and cargo fmt --check clean.

🤖 Generated with Claude Code

rowan-claude and others added 3 commits November 9, 2026 22:58
Every test in tests/client_server.rs binds real localhost UDP sockets and sleeps between updates, so they are functional tests. Mark each #[ignore] so a plain cargo test binds no socket and does not sleep, and add a functional CI job on Linux, macOS and Windows that runs them with cargo test --test client_server -- --ignored.

By: Rowan

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@rowan-claude
rowan-claude merged commit a596e6b into main Nov 10, 2026
15 checks passed
@rowan-claude
rowan-claude deleted the rowan/client-server-functional branch November 10, 2026 04:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant