Repository navigation
Run the client/server socket tests only with --ignored - #68
Merged
Merged
Conversation
Every test in tests/client_server.rs binds real localhost UDP sockets and sleeps between updates, so they are functional tests. Mark each #[ignore] so a plain cargo test binds no socket and does not sleep, and add a functional CI job on Linux, macOS and Windows that runs them with cargo test --test client_server -- --ignored. By: Rowan Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every test in tests/client_server.rs binds real localhost UDP sockets and sleeps between updates, so they are functional tests. This marks each of the 13 with
#[ignore = "functional: binds a real UDP socket; run with --ignored"](the pattern from #66), so a plaincargo testbinds no socket and does not sleep.A new
functionalCI job runscargo test --test client_server -- --ignoredon Linux, macOS and Windows, in parallel with the other jobs, so the coverage thetestmatrix had stays in CI.Verified on Linux x86_64:
cargo testpasses with client_server 13 ignored;cargo test --test client_server -- --ignoredpasses 13/13;cargo clippy --all-targets -- -D warningsandcargo fmt --checkclean.🤖 Generated with Claude Code