Skip to content

Port reviewer self-destruct + tight-PR norm to claude-gh / claude-jira / claude-local / .claude (post-#160) #162

Description

@martin-conur

Summary

PR #160 introduced two prompt-doc improvements in the claude-notion loadout only:

  1. Reviewer self-destruct — the /reviewer worker, after posting its PR comment + radioing PM, runs task-done --remove-worktree as its final action (single-shot, self-cleaning) instead of idling with the tab open.
  2. Tight-PR norm — reviewer frames every finding as fix-in-this-PR (no "defer to follow-up" for in-scope work); PM forwards all in-scope findings (blockers + nits) in one changes-requested round and grooms only genuinely out-of-scope work into a ticket.
  3. Plus a PM-side note that Bash(task-reviewer *) should be allowlisted in the project's .claude/settings.json for hands-off dispatch, and a review-complete-with-findings tweak ("read its verdict on your next radio check, then forward").

#160's own body explicitly deferred porting these to the other loadouts. This ticket is that port.

Reference

The canonical diff to replicate is PR #160 (branch chore/reviewer-self-destruct-tight-pr), which edits three claude-notion files:

  • claude-notion/commands/reviewer.md — steps 7 & 9 (idle → auto-destruct) + tight-PR norm paragraph after the verdict step.
  • claude-notion/commands/pm.md — Bash(task-reviewer *) permission note, review-complete-with-findings tweak, tight-PR norm paragraph, and the "reviewer tab stays open" → "single-shot and self-cleaning" rewrite.
  • claude-notion/steering/notion-workflow.example.md — two new sections: "Reviewer role (single-shot, self-cleaning)" and "Tight-PR norm — minimize deferrals".

This worktree is forked from #160's branch, so the claude-notion changes are already present here as the live reference — diff them against origin/main to see exactly what to mirror.

Scope — port to the 4 remaining loadouts (12 files)

Apply the equivalent changes, adapting tracker-specific wording (spec source, MCP/CLI references) — do NOT copy claude-notion's Notion-specific phrasing verbatim:

Loadout reviewer prompt pm prompt workflow/steering doc
.claude (dogfood) .claude/commands/reviewer.md .claude/commands/pm.md .claude/gh-workflow.md
claude-gh claude-gh/commands/reviewer.md claude-gh/commands/pm.md claude-gh/steering/gh-workflow.example.md
claude-jira claude-jira/commands/reviewer.md claude-jira/commands/pm.md claude-jira/steering/jira-workflow.example.md
claude-local claude-local/commands/reviewer.md claude-local/commands/pm.md claude-local/steering/local-workflow.example.md

Tracker-specific adaptations:

  • claude-gh / .claude — spec lives in a GitHub issue; use gh issue view. (.claude is the dogfood copy and tracks GitHub, hence gh-workflow.md.)
  • claude-jira — spec is a Jira issue (key like PROJ-123) via the Atlassian MCP; keep the existing Jira phrasing.
  • claude-local — spec is a local task file/slug; keep the existing local-file phrasing.
  • The self-destruct mechanic (task-done --remove-worktree), the tight-PR norm, and the Bash(task-reviewer *) allowlist note are tracker-agnostic — port them faithfully.

Out of scope

Acceptance criteria

  • All 12 files above carry the self-destruct + tight-PR norm + Bash(task-reviewer *) changes, with tracker-appropriate wording.
  • Each loadout's reviewer prompt instructs task-done --remove-worktree as the final action (no "idle, tab stays open").
  • No claude-notion regressions (already done in claude-notion: reviewer self-destruct + tight-PR norm + PM reviewer perms #160 — don't re-touch it) and no kiro changes.
  • tools/check-drift.sh still passes (it covers bin/task-reviewer only, but run it to be safe).
  • Existing test suites stay green.

Sequencing note

This PR is stacked on #160 (forked from chore/reviewer-self-destruct-tight-pr, targets main). Until #160 merges, this PR's diff will include #160's claude-notion changes; that resolves once #160 lands. Review/merge #160 first where possible.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions