release v0.8.4-rc.0: ci: upload desktop artifacts to R2, mac landing page downloads Electron dmg#205
Closed
jsyqrt wants to merge 17 commits into
Closed
release v0.8.4-rc.0: ci: upload desktop artifacts to R2, mac landing page downloads Electron dmg#205jsyqrt wants to merge 17 commits into
jsyqrt wants to merge 17 commits into
Conversation
Add build-desktop dependency to upload-to-hub job and include Markus-*.dmg, *.exe, *.AppImage in the R2 upload loop so the Hub /api/releases/latest API can serve desktop app downloads from the CN-optimized R2 endpoint. Co-authored-by: Cursor <cursoragent@cursor.com>
…page downloads Electron dmg
…x executableName - Add APPLE_APP_SPECIFIC_PASSWORD env var (electron-builder requires this for notarization, not APPLE_ID_PASSWORD) - Set linux.executableName to 'markus' in electron-builder.yml to avoid the scoped package name @markus/desktop producing invalid '@markusdesktop' Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
electron-builder requires homepage, author email, and maintainer metadata when building .deb packages. AppImage was unaffected. Co-authored-by: Cursor <cursoragent@cursor.com>
- Add task.completionSummary field to replace synthetic branch deliverables - Remove branch injection in agent-manager, pass completionSummary directly - Update submitForReview to persist completionSummary to DB - Switch Work page deliverables tab to query unified table via API - Update /api/tasks/deliverables to aggregate from unified table - Remove migrateFromTasks startup migration, add cleanupLegacyRows - Add migrateBranchToCompletionSummary one-time migration - Show full datetime in Deliverables page metadata Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
systray2 is only used by the binary installer's tray controller (tray.mjs), not by the npm CLI entry point (markus.mjs). Keeping it in dependencies causes npm install crashes on newer npm/Node versions due to a bug in @npmcli/arborist resolving systray2's dependency tree. Co-authored-by: Cursor <cursoragent@cursor.com>
Remove redundant build targets now that Electron desktop app is the primary distribution for macOS/Windows: - Drop binary installers for macOS (.pkg) and Windows (.exe) - Drop macOS x64 desktop build (Rosetta handles arm64) - Drop macOS zip targets and Linux .deb from Electron - Drop Mac App Store (MAS) build entirely - Rename build-binaries → build-server-binary (Linux-only) - Simplify GitHub Release notes - Update distribution docs Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…s-platform issues - Remove tray.ts (433 lines dead code) and systray2 dependency entirely - Clean all tray references from build.mjs, build-binary.sh (VBS launcher, systray2 install/verify, .desktop files now use `markus start`) - Add darwin-x64 back to Electron build matrix for Intel Mac users - Fix Windows PATH separator (`:` → `path.delimiter`) - Fix macOS-only CSS padding applied on all platforms - Fix tray icon path in packaged Electron builds - Fix log filename parsing on Windows Co-authored-by: Cursor <cursoragent@cursor.com>
- shell.ts: use cmd.exe on Windows instead of hardcoded sh -c - process-manager.ts: same cmd.exe fix for background_exec - shell-session.ts: use COMSPEC on Windows, /Q flag for cmd.exe - shell.ts: fix process group kill (negative PID is Unix-only) - protocol.ts: handle markus:// deep links on Windows/Linux via second-instance argv and cold-start process.argv Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
…4-rc.7) - agent-manager-extended: update submitForReview assertion to expect 4 args (reviewerId and completionSummary were added to the interface) - api-server-deep: replace setImmediate tick-based waitForResponse with time-based polling (5s timeout) to handle async crypto operations (PBKDF2 hashPassword + JWT signToken) in auth/init handler Co-authored-by: Cursor <cursoragent@cursor.com>
…rc.8) - Delete install.ps1 (Windows users use Desktop App or npm directly) - build-binary.sh: remove macOS .pkg and Windows Inno Setup (Linux only) - install.sh: redirect non-Linux users to Node.js/Desktop App - Update README, README.zh-CN, RELEASE-AND-DISTRIBUTION.md, desktop README - Remove install.ps1 references from publish.yml, quick-release.sh Co-authored-by: Cursor <cursoragent@cursor.com>
jsyqrt
force-pushed
the
release/v0.8.4-rc.0
branch
from
b257a8f to
34cb28e
Compare
quick-release.sh used sed to match root version in sub-packages, which silently skipped packages with a different version string. Replaced with node -e to set version unconditionally. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump v0.8.3 → v0.8.4-rc.0