fix: keep CSS sourcemaps for <style> blocks in dev - #291
Conversation
The dep optimizer compiled templates with `sourceMaps: "inline"`, which drops the extracted style block's separate map, leaving the dev server unable to trace the virtual `.marko-virtual.<ext>` file (spurious "Sourcemap ... points to missing source files" warning). It now uses `"both"`, and the entry configs no longer force `sourceMaps: false`.
🦋 Changeset detectedLatest commit: d780d00 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 59 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Description
Fixes a spurious
Sourcemap for "<template>.marko-virtual.scss" points to missing source filesdev warning for templates with a<style>block.The dep optimizer compiled
.markofiles withsourceMaps: "inline", which drops the extracted style block's separate sourcemap; the shared compiler cache then left the dev server serving the virtual CSS with no map to trace it back to the template, so the style preprocessor emitted a self-referential map to the (non-existent) virtual file. The optimizer now usessourceMaps: "both"(retains the separate map with source content), and the entry compile configs no longer forcesourceMaps: false.Motivation and Context
Reported: templates with a
<style>block emit the warning on a cold dev start. Depends on the paired compiler change (marko-js/marko#3428) so entry compiles keep CSS maps without also emitting a pointless entry-wrapper map.Checklist:
Generated by Claude Code