Skip to content

fix: keep CSS sourcemaps for <style> blocks in dev - #291

Merged
DylanPiercey merged 1 commit into
mainfrom
claude/marko-sourcemap-scss-warning-t41vr3
Jul 14, 2026
Merged

fix: keep CSS sourcemaps for <style> blocks in dev#291
DylanPiercey merged 1 commit into
mainfrom
claude/marko-sourcemap-scss-warning-t41vr3

Conversation

@DylanPiercey

Copy link
Copy Markdown
Contributor

Description

Fixes a spurious Sourcemap for "<template>.marko-virtual.scss" points to missing source files dev warning for templates with a <style> block.

The dep optimizer compiled .marko files with sourceMaps: "inline", which drops the extracted style block's separate sourcemap; the shared compiler cache then left the dev server serving the virtual CSS with no map to trace it back to the template, so the style preprocessor emitted a self-referential map to the (non-existent) virtual file. The optimizer now uses sourceMaps: "both" (retains the separate map with source content), and the entry compile configs no longer force sourceMaps: false.

Motivation and Context

Reported: templates with a <style> block emit the warning on a cold dev start. Depends on the paired compiler change (marko-js/marko#3428) so entry compiles keep CSS maps without also emitting a pointless entry-wrapper map.

Checklist:

  • I have updated/added documentation affected by my changes.
  • I have added tests to cover my changes.

Generated by Claude Code

The dep optimizer compiled templates with `sourceMaps: "inline"`, which
drops the extracted style block's separate map, leaving the dev server
unable to trace the virtual `.marko-virtual.<ext>` file (spurious
"Sourcemap ... points to missing source files" warning). It now uses
`"both"`, and the entry configs no longer force `sourceMaps: false`.
@changeset-bot

changeset-bot Bot commented Jul 14, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d780d00

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@marko/vite Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 59 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: a79016df-befc-4e72-9dd4-81467d346cc8

📥 Commits

Reviewing files that changed from the base of the PR and between c2dcec8 and d780d00.

📒 Files selected for processing (3)
  • .changeset/fix-scss-virtual-sourcemap-warning.md
  • src/index.ts
  • src/rolldown-plugin.ts
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/marko-sourcemap-scss-warning-t41vr3

Comment @coderabbitai help to get the list of available commands.

@DylanPiercey
DylanPiercey merged commit dc6d57b into main Jul 14, 2026
7 checks passed
@github-actions github-actions Bot mentioned this pull request Jul 14, 2026
@github-project-automation github-project-automation Bot moved this from Todo to Done in Roadmap Jul 14, 2026
@github-project-automation github-project-automation Bot moved this to Todo in Roadmap Jul 14, 2026
@DylanPiercey DylanPiercey self-assigned this Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant