feat(vnext): add disposable completion info#200
Merged
Conversation
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
Light2Dark
marked this pull request as ready for review
July 25, 2026 17:40
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
e07f8e525d6e6f2c7f73e24acd4e1f0b1ff90cc0Stacked on #199, now merged into
dev-refactor.Summary by cubic
Adds opt-in rich completion info to the vNext CodeMirror adapter. Introduces a type-safe
infoResolverthat returns a disposable DOM panel, with automatic abort and cleanup on selection or editor changes.New Features
autocomplete.infoResolver(item, { signal })lets you render rich info and return{ dom, destroy }; pending work is aborted and resolved resources are destroyed on option selection changes, document/context/region updates, or view disposal.SqlCompletionInfoResolver,SqlCompletionInfoResolverContext, andSqlDisposableCompletionInfofromsrc/vnext/codemirror/index.ts.Migration
sqlEditor({ autocomplete: { infoResolver } }).AbortSignaland return{ dom, destroy }ornull.Written for commit e07f8e5. Summary will update on new commits.