Skip to content

Changes for the approved custom runtime SUP - #203

Open
phil-abb wants to merge 11 commits into
pre-draftfrom
pdp/custom-runtime-support-SUP
Open

Changes for the approved custom runtime SUP#203
phil-abb wants to merge 11 commits into
pre-draftfrom
pdp/custom-runtime-support-SUP

Conversation

@phil-abb

@phil-abb phil-abb commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Description

Changes for the approved custom runtime SUP

Issues Addressed

List and link all the issues addressed by this PR.

Change Type

Please select the relevant options:

  • Fix (change that resolves an issue)
  • New enhancement (change that adds specification content)
  • Content edits (change that edits existing content)

Checklist

  • I have read the CONTRIBUTING document.
  • My changes adhere to the established patterns, and best practices.

@phil-abb

phil-abb commented Aug 7, 2026

Copy link
Copy Markdown
Contributor Author

I've created the draft PR even though I'm still working on these changes, so people can see what is being done with this if they are interested.

@phil-abb phil-abb changed the title [DRAFT] Changes for the approved custom runtime SUP Changes for the approved custom runtime SUP Aug 10, 2026
@phil-abb
phil-abb marked this pull request as ready for review August 10, 2026 16:35
@phil-abb
phil-abb requested a review from a team as a code owner August 10, 2026 16:35
@phil-abb

phil-abb commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

@margo/technical-wg / @margo/development-team - The specification changes to support deploying applications requiring a custom runtime are ready for review.

This is a companion PR to add the new folder to the site nav: margo/documentation_website#5

Comment thread src/specification/applications/resources/index.md.jinja2 Outdated
Comment thread src/specification/applications/resources/index.md.jinja2
Comment thread src/specification/applications/resources/index.md.jinja2
itemSelector:
matchExpressions:
- key: /type
operator: In

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description calls this property selectorOperator

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nilanjan-samajdar - It's unclear what you are suggesting here. The property name is "operator," and the property type in the LinkML/OpenAPI documentation is "SelectorOperator". Are you suggesting that the property type should also be "Operator," or something else?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nilanjan-samajdar - Just following up on my reply to your statement.

operator: In
values: ["gpu"]
- key: /manufacturer
operator: In

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description calls this property selectorOperator

itemSelector:
matchExpressions:
- key: /type
operator: In

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description calls this property selectorOperator

operator: In
values: ["gpu"]
- key: /manufacturer
operator: In

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description calls this property selectorOperator

operator: In
values: ["NVIDIA"]
- key: /interfaces
operator: ContainsAll

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description calls this property selectorOperator

itemSelector:
matchExpressions:
- key: /type
operator: In

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description calls this property selectorOperator

Comment thread src/specification/applications/resources/index.md.jinja2
Signed-off-by: Philip <philip.presson@us.abb.com>
Signed-off-by: Philip <philip.presson@us.abb.com>
Signed-off-by: Philip <philip.presson@us.abb.com>
Signed-off-by: Philip <philip.presson@us.abb.com>
Signed-off-by: Philip <philip.presson@us.abb.com>
Signed-off-by: Philip <philip.presson@us.abb.com>
Signed-off-by: Philip <philip.presson@us.abb.com>
Signed-off-by: Philip <philip.presson@us.abb.com>
Signed-off-by: Philip <philip.presson@us.abb.com>
@phil-abb
phil-abb force-pushed the pdp/custom-runtime-support-SUP branch from 55bb8e8 to e3f7d21 Compare August 21, 2026 15:31
Signed-off-by: Philip <philip.presson@us.abb.com>
@phil-abb

Copy link
Copy Markdown
Contributor Author

Updated the LinkML version to match the changes in this PR because I was getting build errors with some of the changes needed.

Signed-off-by: Philip Presson <philip.presson@us.abb.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Develop Margo standard feature enabling application developers to target device specific runtime environments

3 participants