Fix draw tool menu layering over mode hints - #1010
Open
zzzhangy wants to merge 1 commit into
Open
Conversation
chriswhong
requested changes
Jun 24, 2026
| export const DDContent = classed(DD.Content)(contentLike); | ||
| export const CMContent = classed(CM.Content)(contentLike); | ||
| export const CMSubContent = classed(CM.SubContent)(contentLike); | ||
| const floatingContentLike = `${contentLike} z-50`; |
Contributor
There was a problem hiding this comment.
Can you add a comment here explaining why these three elements need a different z-index?
| className={clsx( | ||
| 'z-0 absolute top-2 left-2 px-2 text-sm flex gap-x-2 items-center dark:text-white', | ||
| contentLike | ||
| 'absolute top-2 left-2 px-2 text-sm flex gap-x-2 items-center dark:text-white', |
Contributor
There was a problem hiding this comment.
Can we just replace z-0 with z-10 in the same string on line 26?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1000
Validation
npx prettier --check "app/components/elements.tsx" "app/components/mode_hints.tsx"npx eslint "app/components/elements.tsx" "app/components/mode_hints.tsx"git diff --checknpm run buildnpm testz-index: 50, mode hint computedz-index: 10, and the overlap point resolves to theMercatormenu item.