Skip to content

skills: point consumer skills at given: instead of #(filter) - #1081

Closed
jswir wants to merge 2 commits into
mainfrom
skills/deprecate-filter-in-consumer-skills
Closed

skills: point consumer skills at given: instead of #(filter)#1081
jswir wants to merge 2 commits into
mainfrom
skills/deprecate-filter-in-consumer-skills

Conversation

@jswir

@jswir jswir commented Aug 27, 2026

Copy link
Copy Markdown
Collaborator

malloy-model and malloy-notebooks already mark #(filter) legacy and document given: as the replacement. Four consumer-facing skills were never updated and still present #(filter) as the current mechanism:

  • malloy-analyze — tells the agent to add a #(filter) to the source when the analysis needs a knob the model doesn't expose.
  • malloy-define — instructs the agent to write #(filter) annotations into a model it is authoring. This is the one that actually produces new #(filter) in new models.
  • malloy-document — its annotation table and its #(filter) section both describe it as current, and point at a malloy-model section heading that no longer exists under that name.
  • malloy-analysis-report — same as malloy-analyze, for reports.

Each now points at given: and names the two exceptions malloy-model already documents — required and implicit — so the guidance doesn't overshoot into cases given: cannot cover yet.

Found while following malloy-reproducible-analysis on a real analysis: the model-authoring path recommended #(filter) with nothing marking it deprecated, and the stale cross-reference in malloy-document sent the reader to a heading that had already been renamed to Legacy: Parameterizable Filters.

Docs only, no code. Independent of #1079 — no overlapping files.

jswir added 2 commits August 26, 2026 23:57
malloy-model and malloy-notebooks already mark #(filter) legacy and document
given: as the replacement. Four consumer-facing skills were never updated and
still present #(filter) as the current mechanism - malloy-define even tells the
agent to write new #(filter) annotations into a model it is authoring.

Each now points at given: and names the two exceptions malloy-model already
documents, required and implicit, so the guidance does not overshoot into cases
given: cannot cover yet.

Signed-off-by: James Swirhun <james@credibledata.com>
The bundle embeds each skill's full body, so the served copy was stale after
the previous commit's edits.

Signed-off-by: James Swirhun <james@credibledata.com>
@jswir

jswir commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator Author

Superseded by #1079, which carries this commit cherry-picked unchanged (87597a24).

Folding it there rather than merging separately: it was unreviewed, it is the same class of change as that PR, and it was the last thing blocking the skills PR that retires malloy-analyze — one of the four files this touches.

@jswir jswir closed this Aug 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant