skills: point consumer skills at given: instead of #(filter) - #1081
Closed
jswir wants to merge 2 commits into
Closed
skills: point consumer skills at given: instead of #(filter)#1081jswir wants to merge 2 commits into
jswir wants to merge 2 commits into
Conversation
malloy-model and malloy-notebooks already mark #(filter) legacy and document given: as the replacement. Four consumer-facing skills were never updated and still present #(filter) as the current mechanism - malloy-define even tells the agent to write new #(filter) annotations into a model it is authoring. Each now points at given: and names the two exceptions malloy-model already documents, required and implicit, so the guidance does not overshoot into cases given: cannot cover yet. Signed-off-by: James Swirhun <james@credibledata.com>
The bundle embeds each skill's full body, so the served copy was stale after the previous commit's edits. Signed-off-by: James Swirhun <james@credibledata.com>
Collaborator
Author
|
Superseded by #1079, which carries this commit cherry-picked unchanged ( Folding it there rather than merging separately: it was unreviewed, it is the same class of change as that PR, and it was the last thing blocking the skills PR that retires |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
malloy-modelandmalloy-notebooksalready mark#(filter)legacy and documentgiven:as the replacement. Four consumer-facing skills were never updated and still present#(filter)as the current mechanism:malloy-analyze— tells the agent to add a#(filter)to the source when the analysis needs a knob the model doesn't expose.malloy-define— instructs the agent to write#(filter)annotations into a model it is authoring. This is the one that actually produces new#(filter)in new models.malloy-document— its annotation table and its#(filter)section both describe it as current, and point at amalloy-modelsection heading that no longer exists under that name.malloy-analysis-report— same asmalloy-analyze, for reports.Each now points at
given:and names the two exceptionsmalloy-modelalready documents —requiredandimplicit— so the guidance doesn't overshoot into casesgiven:cannot cover yet.Found while following
malloy-reproducible-analysison a real analysis: the model-authoring path recommended#(filter)with nothing marking it deprecated, and the stale cross-reference inmalloy-documentsent the reader to a heading that had already been renamed to Legacy: Parameterizable Filters.Docs only, no code. Independent of #1079 — no overlapping files.