Add tests documenting aggregate strategy across join_many legs - #2873
Open
aszenz wants to merge 1 commit into
Open
Add tests documenting aggregate strategy across join_many legs#2873aszenz wants to merge 1 commit into
aszenz wants to merge 1 commit into
Conversation
Pins when the compiler switches from plain aggregates to symmetric aggregates: one fanning leg stays plain, two legs in a stage fan out and go symmetric, pre-aggregated join_one legs stay plain. Baseline for the performance problem described in malloydata#2872. Signed-off-by: asrar <aszenz@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Repro tests for #2872.
Documents when the compiler switches between plain and symmetric aggregates across
join_manylegs, on the synthetic shape from the issue (1,000 parents × two 30-row legs, expected totals 465,000):SUMjoin_one→ plainSUMsTests run against in-repo DuckDB only (the strategy choice is dialect-independent; only its cost differs), so they're cheap and assert both the SQL shape and the correct totals.