Skip to content

[Bug]: v1.7.0 silently broke api_url values containing /v3 [breaking change] #40

Description

@arbroen

Version

1.7

Operating System

Linux

Python Version

3.14

What happened?

Summary

v1.6.0 built per-version URLs with urljoin:

v3_base = urljoin(self.api_url, "v3/")

urljoin("https://api.eu.mailgun.net/v3", "v3/") 
#  "https://api.eu.mailgun.net/v3/" 
# the relative v3/ replaces the trailing segment, so an api_url containing /v3 worked fine.

v1.7.0 switched to f-string concat:

self._baked_urls = {ver.value: f"{self.api_url}/{ver.value}" for ver in APIVersion}

# Now /v3 is appended unconditionally 
# https://api.eu.mailgun.net/v3/v3/... → every request 404s.

Since this is missing from the Changelog or releases info I'm assuming this is regression.

Kind regards

Steps to reproduce

Use https://api.eu.mailgun.net/v3/ as a base_url.

Relevant log output

Additional information

No response

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

bugSomething isn't workingtriageTriage is required

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions