Test ECH + HTTP proxy - #9671
Merged
Merged
Conversation
We had a bug where we incorrectly sent the proxy's ECH config list to the origin server. That wouldn't have worked.
swankjesse
commented
Aug 14, 2026
| when (proxy.type()) { | ||
| Proxy.Type.DIRECT -> serviceMetadata?.echConfigList | ||
| else -> null | ||
| }, |
Collaborator
Author
There was a problem hiding this comment.
This was a pretty nasty one. We sent the proxy’s ECH config list to the origin server
Collaborator
Author
There was a problem hiding this comment.
This would have manifested as a connectivity problem for clients that use an HTTP proxy, if the HTTP proxy itself has an ECH record. Possibly not likely in practice? Unsure.
Collaborator
Author
There was a problem hiding this comment.
Also, I love tests. That’s how we build complex things safely!
yschimke
approved these changes
Aug 14, 2026
| when (proxy.type()) { | ||
| Proxy.Type.DIRECT -> serviceMetadata?.echConfigList | ||
| else -> null | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We had a bug where we incorrectly sent the proxy's ECH config list to the origin server. That wouldn't have worked.