Don't close the multipart sink when a part closes its stream - #9659
Open
iVamsi wants to merge 4 commits into
Open
Don't close the multipart sink when a part closes its stream#9659iVamsi wants to merge 4 commits into
iVamsi wants to merge 4 commits into
Conversation
Collaborator
|
This seems like it fixes a very specific variant of this bug, but not the whole class of bug. |
iVamsi
changed the title
Contributor
Author
|
@JakeWharton Yeah, gzip was just one body that closed the sink. Moved the fix to MultipartBody. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A request body closing its sink was also closing the stream that OkHttp was still writing to. In a multipart request, that meant the next part (or even the bytes after the first part) failed with IllegalStateException: closed.
The part still needs to finish its stream. This change lets it do that without closing the stream MultipartBody was handed.
Fixes #7692.