Skip to content

Ameba 1.7#2045

Merged
jwoertink merged 19 commits into
luckyframework:mainfrom
Sija:ameba-1.7
Jun 22, 2026
Merged

Ameba 1.7#2045
jwoertink merged 19 commits into
luckyframework:mainfrom
Sija:ameba-1.7

Conversation

@Sija

@Sija Sija commented Jun 20, 2026

Copy link
Copy Markdown
Contributor

Purpose

This PR updates the Ameba linter to the latest (unreleased yet) v1.7.0-dev.

@jwoertink jwoertink left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this together! I guess Ameba takes care of the format check now and fails if the code isn't formatted fully, right? If so, then I think this will be ready to merge.

Comment thread .github/workflows/ci.yml
Comment thread spec/lucky/form_helpers_spec.cr
@Sija

Sija commented Jun 21, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for putting this together! I guess Ameba takes care of the format check now and fails if the code isn't formatted fully, right?

That's exactly the case 👍

@jwoertink jwoertink merged commit ad81be0 into luckyframework:main Jun 22, 2026
9 checks passed
@Sija Sija mentioned this pull request Jun 22, 2026
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants