Repository navigation
feat: notify from a Control Kill source and test on GNOME Shell 46 to 51 - #7
Open
lucaswotta wants to merge 2 commits into
Open
lucaswotta wants to merge 2 commits into
lucaswotta wants to merge 2 commits into
Conversation
Main.notify() files notifications under the shell's generic System source. The extension now creates its own MessageTray.Source, titled Control Kill and carrying a symbolic icon shipped in the package, adds it to the message tray when first needed and destroys it in disable(). The constructor and the calls were read in js/ui/messageTray.js and main.js of GNOME Shell 46.0, 47.0, 48.0, 49.0, 50.0 and 51.0: getSystemSource() builds its source the same way in all of them (Source with title and icon, destroy handler, Main.messageTray.add) and Notification takes an object with source, title, body and isTransient. tests/shell.js now checks the source title, its icon and that disable() removes it; with the previous code those four checks fail. Refs #1.
One container per release (ubuntu:24.04, fedora:41 to rawhide) runs tests/container.sh. Shell 51 disables extensions asynchronously, so the disable checks now wait for the extension to leave the active state. Part of #3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1. Part of #3.
Problem: notifications went through
Main.notify, so the shell showed them under its generic "System" source with no icon. CI ran no test against the shell.Change:
extension.jscreates aMessageTray.Sourcetitled "Control Kill" withicons/control-kill-symbolic.svgand sends notifications through it;disable()destroys it. TheSourcepattern is identical in 46 to 51 upstream.tests/container.shinstalls what a bare Ubuntu or Fedora image lacks and runsmake test-shell. A newshellCI job runs it onubuntu:24.04(46) andfedora:41tofedora:rawhide(47 to 51).tests/shell.jschecks the source title, the icon and that the source is gone after disable. It now waits for the extension to leave the active state, because shell 51 disables extensions asynchronously.Tested:
make checkpasses;tests/container.shpasses in all six images locally (46.0, 47.10, 48.8, 49.10, 50.6, 51.1); the four new checks fail on the previous code. Theshelljob itself has not run on GitHub yet;actions/checkoutin images withoutgitis the part not verified locally.No version bump and no change for extensions.gnome.org.