Open
Conversation
When a Nightscout reading exceeds maxDisplayGlucose (400 mg/dL), the main display correctly shows "HIGH" but the chart was plotting the raw value (e.g. 550) and autoscaling the y-axis up to 600. This makes the chart inconsistent with the header. Clamp the plotted y-value in updateBGGraph to [minDisplayGlucose, maxDisplayGlucose] so the chart line stays within the same range the display text represents. The pill tooltip still shows the raw reading so the exact value is accessible on tap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When a Nightscout reading exceeds
maxDisplayGlucose(400 mg/dL), the main header correctly shows HIGH but the chart plots the raw value (e.g. 550) and autoscales the y-axis up to 600. This makes the chart inconsistent with the header text.This PR clamps the plotted y-value in
updateBGGraphto[minDisplayGlucose, maxDisplayGlucose](39–400 mg/dL) so the chart line stays within the range the header represents. The pill tooltip still shows the raw reading so the exact value is accessible on tap.bgData, stats, alarms, and color coding are unaffected.DeviceStatusLoop,DeviceStatusOpenAPS), so the graph is now consistent across both data types.Globals.swiftcomment to reflect the broader usage of the constants.