Skip to content

Add command to query contract information by address. - #1356

Merged
enlight merged 45 commits into
masterfrom
query-contract-info
Jul 31, 2019
Merged

Add command to query contract information by address.#1356
enlight merged 45 commits into
masterfrom
query-contract-info

Conversation

@atchapcyp

Copy link
Copy Markdown
Contributor

This PR is to implement loomchain command to query contract information by contract address.
for example loom contract default:0x1234...
In order to do that we need...

  • Add rpc client in go-loom that call contractrecord method to loomchain
  • Add contractrecord route on query service
  • Add function GetContractRecord on query server and middleware
  • Add loom contract command
  • Add unit test and E2E test

ref : loomnetwork/go-loom#428, #450

  • I added unit tests for any code that added
  • I updated the CHANGELOG.md
  • All IP is original and not copied from another source
  • I assign all copyright to Loom Network for the code in the pull request

Comment thread e2e/deploygo-1-test.toml Outdated
Comment thread rpc/query_server.go Outdated
Comment thread rpc/query_server.go Outdated
Comment thread rpc/query_server_test.go Outdated
Comment thread rpc/query_server_test.go Outdated
Comment thread rpc/query_server.go Outdated
Comment thread e2e/engine/cmd.go Outdated
Comment thread cmd/loom/loom.go Outdated
Comment thread Makefile Outdated

@enlight enlight left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@enlight
enlight merged commit 9ce198e into master Jul 31, 2019
@enlight
enlight deleted the query-contract-info branch July 31, 2019 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants