Skip to content

Deployer permission override - #1007

Closed
pathornteng wants to merge 2875 commits into
masterfrom
default-deployer
Closed

Deployer permission override#1007
pathornteng wants to merge 2875 commits into
masterfrom
default-deployer

Conversation

@pathornteng

@pathornteng pathornteng commented Apr 17, 2019

Copy link
Copy Markdown
Contributor
  • I added unit tests for any code that added
  • I updated the CHANGELOG.md
  • All IP is original and not copied from another source
  • I assign all copyright to Loom Network for the code in the pull request

Issue: #981
go-loom: loomnetwork/go-loom#355

aupiff and others added 30 commits March 18, 2019 17:33
Testing & Candidate Updates
- Inline enableFeature
- Add missing request validation checks
- Make getParams return default initialized struct when no params are set
- Fix attempts to read unarmshaled struct on proto.Unmarshal error
- Add comments
Really the current validator set should be available through
Validators() on the contract context, but that doesn't appear to be
hooked up to DPOSv2, only v1, so we have to make a direct call into the
DPOSv2 contract for now.
aupiff and others added 13 commits April 14, 2019 21:41
* Restrict line length to 120 chars
* Lower linter error threshold to 136
dPoS docs & referral improvements
Load dposv3 when set in the loom.yml
* Fix cluster readiness check in e2e test runner

Previous implementation didn't actually work properly.

* Increase max retries to 5 while waiting for nodes to start up

coin-2 really doesn't like starting up in timely fashion sometimes.
…rom PR 886 (#1001)

- Fix review issues from #886
- Write websocket response in a separate go-routine, to avoid concurrency issues.
@pathornteng pathornteng self-assigned this Apr 17, 2019
pathornteng and others added 3 commits April 17, 2019 16:35
* Compress and move test data

* Only include logs

* Reorder
Comment thread cmd/loom/deployerwhitelist/cmd.go Outdated
Comment thread cmd/loom/deployerwhitelist/cmd.go Outdated
Comment thread builtin/plugins/deployer_whitelist/deployer_whitelist.go Outdated
Comment thread builtin/plugins/deployer_whitelist/deployer_whitelist.go Outdated
Comment thread builtin/plugins/deployer_whitelist/deployer_whitelist.go Outdated
Comment thread builtin/plugins/deployer_whitelist/deployer_whitelist.go Outdated
Comment thread cmd/loom/deployerwhitelist/cmd.go Outdated
Comment thread throttle/deployer-middleware.go Outdated
adyromantika and others added 3 commits April 17, 2019 23:30
Force the ChainConfigManager to panic if it tries to enable a feature that's not supported by the current build. This should safely prevent the node from processing any further blocks in case a feature it doesn't support is activated by the rest of the chain. To make this work features now have a minimum build number associated with them, which must be specified by the ChainConfig contract owner when adding new features.

The new functionality is not behind a feature flag, so once this is deployed to production new features can't be added until the whole cluster upgrades to a new build.
* URI support in e2e test runner
* URI support in coin tests
* Coin command migration to go-loom
* URI FLag support in sendtx
* URI support in util.go
@pathornteng pathornteng changed the title Default deployer permission Deployer permission override Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants