Open
Conversation
silv-io
requested review from
anisaoshafi and
carole-lavillonniere
as code owners
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review to trigger a review and subscribe this PR to future pushes, or @claude review once for a one-time review.
Tip: disable this comment in your organization's Code Review settings.
anisaoshafi
reviewed
Apr 8, 2026
Contributor
anisaoshafi
left a comment
anisaoshafi
left a comment
There was a problem hiding this comment.
Nice optimization 👏🏼
Could you please clean up the cache file in cleanupLicense?
Also, would be great to add an integration test
silv-io
force-pushed
the
flc-546-cache-and-mount-license-files
branch
from
d557cd7 to
21ef046
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The CLI fetches a license file per emulator/version on every start. This caches it locally to avoid redundant fetches and mounts it into the container so the emulator doesn't need to re-fetch it either.
Changes
GetLicensenow returns([]byte, error)so the license content can be used by the callerconfig.LicenseFilePath()— returns$CACHE_DIR/lstk/license.json(OS-appropriate)/etc/localstack/conf.d/license.jsonTests
Existing integration tests cover the license validation flow. Manual verification of cache write and container mount.
Related