Conversation
abh3po
commented
Jun 18, 2026
abh3po
commented
Collaborator
|
this PR needs to be updated to follow conventional commits message |
|
this PR needs to be updated to follow conventional commits message |
…-driven relay, remove dead createGroup - Remove the malformed react-native-svg+15.15.2.patch: it captured Android build artifacts (android/build/.transforms, classes.dex, generated BuildConfig.java) rather than source. react-native-svg patching is owned by #645, which supersedes this. - Gate the verbose [nip29] publish/join logs behind __DEV__ via nip29Log / nip29Warn so signed events and relay chatter never reach production logs. - Make the default relay + support group id config-driven via react-native-config (NIP29_RELAY_URL / NIP29_SUPPORT_GROUP_ID), with groups.0xchat.com and the support group as defaults — no longer hard-coded. Also route the provider's relayUrls default prop through NIP29_DEFAULT_RELAY_URL. - Remove the unused createGroup from NostrGroupChatProvider (dead code that duplicated the standalone createNip29Group used by CreateGroupModal); drop the now-unused generateSecretKey / bytesToHex imports. No new type errors (tsc unchanged at 87, all pre-existing). Note: react-native-config may need a jest mock when the suite is revived (ENG-433). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
|
Pushed a commit (
Verified |
The three derive-from-EventStore effects returned `store.subscribe(...)` directly as the cleanup, but its unsubscribe returns `boolean`, which violates useEffect's `void` cleanup contract (TS2345). Wrap each so the cleanup discards the return. No runtime change (React ignored the value); clears the 3 tsc errors this PR introduced. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Wrap CreateGroupModal, GroupInfoModal (edit metadata), and GroupMembersModal (member search) sheets in KeyboardAvoidingView with behavior='padding' on iOS. The bottom-anchored modals were being covered by the keyboard when typing in name, about, picture URL, and member search fields.
Take main's Podfile.lock — #645 patched react-native-svg for RN 0.77 Yoga, which supersedes our local version.
Collaborator
|
@abh3po check out the 3 commits i made with the agents pls before we merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.