Make --always-offload-from-vram actually work properly, fixes #3257#3263
Open
infinity0 wants to merge 1 commit into
Open
Make --always-offload-from-vram actually work properly, fixes #3257#3263infinity0 wants to merge 1 commit into
infinity0 wants to merge 1 commit into
Conversation
This was referenced Jul 10, 2024
mashb1t
requested changes
Jul 10, 2024
mashb1t
left a comment
mashb1t
left a comment
Collaborator
There was a problem hiding this comment.
this is in contrast with the comment in https://github.com/infinity0/Fooocus/blob/a3880034e476a4fb5c1c3ba17635b08e5548fe88/ldm_patched/modules/model_management.py#L769, please confirm this makes the handling better instead of worse.
5 tasks
mashb1t
added
bug (AMD)
Author
|
Need @lllyasviel to comment as I have no idea what the original comment is referring to regarding "worse". Works fine over here. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a more conservative alternative to #3262.
See #3257 (comment) / #3258 for details.