Ensure that sortPresets does NOT mutate values passed in via options into Room#1979
Open
1egoman wants to merge 2 commits into
Open
Ensure that sortPresets does NOT mutate values passed in via options into Room#19791egoman wants to merge 2 commits into
1egoman wants to merge 2 commits into
Conversation
…ions into Room What could happen previously is if the user passed in the layers into LiveKitRoom in components-js in the wrong order, then the JSON.stringify comparisons which were being done at that layer could be attempting to compare the sorted (via side effect) version with the new value the user passed in (which has a different ref and would not be sorted), always recreating the room.
🦋 Changeset detectedLatest commit: 53e5575 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What could happen previously is if the user passed in the layers into
LiveKitRoomincomponents-jsin the wrong order, then theJSON.stringify(...)comparison here could be attempting to compare the sorted (via side effect) version with the new value the user passed in (which has a different ref and would not be sorted), always recreating the room on every render.Fixes livekit/components-js#1345
Todo