fix CPU spin on stdin EOF in InteractiveBackend (#42)#54
Merged
Conversation
When stdin reaches EOF (e.g. when screen -dmS detaches from the TTY), getchar_no_echo() returns EOF immediately on every call. The input thread loop had no EOF check, causing a tight CPU spin. Detect EOF and shut down the backend gracefully. Added regression test (regression_issue42.sh) that forces interactive mode with /dev/null as stdin and verifies CPU usage stays near zero. Integrated as a CTest test.
lionkor
force-pushed
the
fix/issue-42-screen-dmS-cpu-spin
branch
from
e2c63c3 to
e5e4f0d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When stdin reaches EOF (e.g. when screen -dmS detaches from the TTY), getchar_no_echo() returns EOF immediately on every call. The input thread loop had no EOF check, causing a tight CPU spin.
Detect EOF and shut down the backend gracefully.
Added regression test (regression_issue42.sh) that forces interactive mode with /dev/null as stdin and verifies CPU usage stays near zero. Integrated as a CTest test.