Skip to content

feat(email): add email worker starter files - #1

Merged
neelkarma merged 9 commits into
mainfrom
neel/email-starter
Sep 4, 2025
Merged

feat(email): add email worker starter files#1
neelkarma merged 9 commits into
mainfrom
neel/email-starter

Conversation

@neelkarma

Copy link
Copy Markdown
Contributor

very bare bones, just using the default cloudflare starter template with a few modifications for the email stuff

@neelkarma
neelkarma requested a review from Copilot August 23, 2025 13:18

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

I'm not sure what the preferred way of formatting is in the repo, so
I'll just remove what's there in the template in case it's wrong
@neelkarma

Copy link
Copy Markdown
Contributor Author

Just added CI, which just runs TypeScript's typechecking for now. I've done a bit of research, and it doesn't seem that you are able to write unit tests for email workers, which is unfortunate.

@fabledsaint fabledsaint left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there, just a bit of a tweak so that we dont have to spam cd's (which aren't consistent anyway)

Comment thread .github/workflows/Email.yml
Comment thread .github/workflows/Email.yml Outdated
Comment thread .github/workflows/Email.yml Outdated
@fabledsaint

Copy link
Copy Markdown
Member

feel free to also add prettier checks (CI) while you're at it.
it's also interesting that the starter doesn't seem to give eslint, would it be a good idea to integrate eslint/prettier or biomejs? @Zopolis4 thoughts on integrating this ci with the existing framework

@neelkarma
neelkarma requested a review from fabledsaint August 28, 2025 04:01
@Zopolis4

Copy link
Copy Markdown
Contributor

@Zopolis4 thoughts on integrating this ci with the existing framework

I guess? It's manually installing pnpm and so on which is in contrast to the existing reviewdog-based designs, and #9 already does the same thing using (in my opinion) cleaner and simpler code, with the benefit of fancy reporting

@fabledsaint fabledsaint left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@neelkarma
neelkarma merged commit 15b18fc into main Sep 4, 2025
4 checks passed
@fabledsaint
fabledsaint deleted the neel/email-starter branch September 5, 2025 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants