Repository navigation
daemon: Show the UI through the backend that the portal selects - #273
Merged
Merged
Conversation
xdg-desktop-portal looks up the backend for org.freedesktop.impl.portal.experimental.Credential in portals.conf and the .portal files, but credentialsd always called xyz.iinuwa.credentialsd.UiControl, so the configuration had no effect. Read the new ui_backend option of CreateCredential and GetCredential, which xdg-desktop-portal sets to the selected backend, and create the UI session there. The name is only read once the caller is trusted, and must be a well-known name. Without the option, as with older xdg-desktop-portal versions, UiControl is used as before. Assisted-by: Claude:claude-opus-5-5
iinuwa
previously approved these changes
Nov 16, 2026
iinuwa
left a comment
Member
There was a problem hiding this comment.
LGTM.
This interface is deprecated, but this will help with backend development in the interim.
iinuwa
approved these changes
Nov 16, 2026
iinuwa
enabled auto-merge
November 16, 2026 20:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
xdg-desktop-portal looks up the backend for
org.freedesktop.impl.portal.experimental.Credential in portals.conf and the .portal files, but credentialsd always called
xyz.iinuwa.credentialsd.UiControl, so the configuration had no effect.
Read the new ui_backend option of CreateCredential and GetCredential, which xdg-desktop-portal sets to the selected backend, and create the UI session there. The name is only read once the caller is trusted, and must be a well-known name. Without the option, as with older xdg-desktop-portal versions, UiControl is used as before.
Assisted-by: Claude:claude-opus-5-5