Repository navigation
Conversation
The root meson.build and the credentialsd and credentialsd-ui subdirs each registered build-aux/dist-vendor.sh. The root and credentialsd registrations both run in the same dist directory, so the second one fails on `mkdir .cargo` and `meson dist` aborts without producing a tarball. Keep the registration in the root meson.build only, which vendors the crates for the whole workspace.
Add distrib/debian/, which builds the daemon, the GTK UI and the browser helper as credentialsd, credentialsd-ui and credentialsd-webextension. It builds offline from the crates that `meson dist` vendors into the source tarball, so it works on the openSUSE Build Service. README.source explains how to make the tarball and what an upload to the Debian archive needs instead (crates packaged on their own).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #268. This adds Debian packaging in
distrib/debian/, next to the Arch PKGBUILD in #269. It builds three packages:credentialsd: the daemon, its D-Bus activation file and systemd user unit.credentialsd-ui: the GTK dialog and the portal backend description.credentialsd-webextension: the Firefox/Chromium helper and the native messaging manifest.It builds offline from the crates that
meson distvendors into the source tarball. That's what OBS needs for Debian/Ubuntu targets.README.sourceexplains how to make the tarball.The first commit fixes
meson dist: the vendoring script was registered three times, and the second run failed onmkdir .cargo, so no tarball was produced.Release mode
Debian builds use the default
profile=release, so they rely on #270. Without it the packages contain debug builds. I tested with #270 applied: all Cargo builds use the release profile, with Rust LTO. Cargo's release profile has no debug info, which left the-dbgsympackages empty, sodebian/rulessetsCARGO_PROFILE_RELEASE_DEBUG=true, anddh_stripmoves the symbols out.Testing
-A,-B, and a rebuild afterclean.initial-upload-closes-no-bugs,no-manual-page, andappstream-metadata-validation-failed. The last one is upstream: the metainfo refers to a.desktopfile that isn't installed.apt installof the three.debs pulls in GTK 4, libnfc and pcsclite.credentialsd-webextension(installed via policy, since ESR allows unsigned extensions), and the patched xdg-desktop-portal built in the VM (1.22.1 + Credential commits). On webauthn.io, registration and then sign-in both went through the extension, the helper, the portal, credentialsd and the dialog, using a virtual FIDO2 key over USB/IP. Stock systemd udev rules give the seat user access to the key.firefox-esr, which the daemon doesn't list as privileged yet. That's fixed in daemon: Treat Debian's Firefox ESR as a privileged client #271.Getting into the Debian archive
This packaging works for OBS and other third-party repositories. The Debian archive needs every crate packaged on its own (
librust-*-dev) instead ofvendor/. I comparedCargo.lockwith Debian sid:An upload also needs an ITP bug and a sponsor. I'll post the full list on #268.
Found while testing (not changed here)
firefox-esr, which wasn't a privileged client: daemon: Treat Debian's Firefox ESR as a privileged client #271.