Skip to content

1d light curve collation utility function#951

Open
SamSandwich07 wants to merge 3 commits into
mainfrom
collate-utils
Open

1d light curve collation utility function#951
SamSandwich07 wants to merge 3 commits into
mainfrom
collate-utils

Conversation

@SamSandwich07

Copy link
Copy Markdown
Collaborator

Introduces collate_utils.py to put utility functions for collation. Adds one such utility function which can be used to pad and mask raw 1D light curves, along with a test for this function.

@SamSandwich07 SamSandwich07 self-assigned this Jun 15, 2026
@SamSandwich07 SamSandwich07 requested a review from mtauraso June 15, 2026 21:58
@codecov

codecov Bot commented Jun 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 63.87%. Comparing base (61d4977) to head (17c9961).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #951      +/-   ##
==========================================
+ Coverage   63.80%   63.87%   +0.07%     
==========================================
  Files          74       75       +1     
  Lines        7689     7704      +15     
==========================================
+ Hits         4906     4921      +15     
  Misses       2783     2783              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SamSandwich07 SamSandwich07 requested a review from drewoldag June 16, 2026 21:30
@mtauraso

Copy link
Copy Markdown
Member

Generally this seems alright to merge. I worry that it is not generic enough to be generally useful (but perhaps I simply haven't been part of the discussions here)

I'm lightly suggesting that we try to talk to folks who would use these collation utilities and try to generalize this, add documentation and examples so we get the full value here. I think a lot of this is human conversational/requirements gathering work, likely leading to a relatively small amount of new code. Not sure if we're on that path yet, but it seems like one we should consider.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants