Implement reduce_dimensions#932
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #932 +/- ##
==========================================
+ Coverage 63.82% 64.38% +0.56%
==========================================
Files 74 81 +7
Lines 7693 7930 +237
==========================================
+ Hits 4910 5106 +196
- Misses 2783 2824 +41 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
drewoldag
left a comment
There was a problem hiding this comment.
This is looking like it's on the right track. Left a few comments, nothing too scary.
drewoldag
left a comment
There was a problem hiding this comment.
This batch of changes look reasonable.
|
At this point all the code/docstring/tests are finished. I will address the documentation updates in a separate PR. |
drewoldag
left a comment
There was a problem hiding this comment.
Approved with a couple of comments to look at. Half are just wording suggestions and can be ignored. The one about refactoring the parallel code can be deferred. The others might be worth looking at.
Change Description
Closes #859
Solution Description
This PR introduces the initial framework for a
reduce_dimensionsverb to support multiple dimensionality reduction algorithms with Hyrax.Current Progress
Added the
reduce_dimensionsverb.Introduced the
ReductionAlgorithmsubclass structure to provide a generalized abstraction layer for dimensionality reduction methods. Migrated the existing UMAP implementation into the newreduce_dimensionsframework while preserving current functionality and behavior.Next Steps
reduce_dimensionsand newly supported algorithms.Code Quality