Skip to content

Correctly refer to pay_for_offer_from_hrn in pay_for_offer docs#4540

Open
TheBlueMatt wants to merge 1 commit intolightningdevkit:mainfrom
TheBlueMatt:2026-04-drop-native-dns
Open

Correctly refer to pay_for_offer_from_hrn in pay_for_offer docs#4540
TheBlueMatt wants to merge 1 commit intolightningdevkit:mainfrom
TheBlueMatt:2026-04-drop-native-dns

Conversation

@TheBlueMatt
Copy link
Copy Markdown
Collaborator

@TheBlueMatt TheBlueMatt commented Apr 3, 2026

If a pay_for_offer call comes in that was for an HRN, downstream code should instead call pay_for_offer_from_hrn, not pay_for_offer.

@ldk-reviews-bot
Copy link
Copy Markdown

ldk-reviews-bot commented Apr 3, 2026 •
edited
Loading

I've assigned @wpaulino as a reviewer!
I'll wait for their review and will help manage the review process.
Once they submit their review, I'll check if a second reviewer would be helpful.

ldk-claude-review-bot
ldk-claude-review-bot reviewed Apr 3, 2026
View reviewed changes
@ldk-claude-review-bot
Copy link
Copy Markdown
Collaborator

ldk-claude-review-bot commented Apr 3, 2026 •
edited
Loading

I've reviewed the full diff and surrounding context. The prior review already caught the only issue — the missing verb "use" before pay_for_offer_from_hrn. The method pay_for_offer_from_hrn exists at line 14614 and the reference is correct. No new issues beyond what was already flagged.

No new issues found.

My prior review already identified the one grammar nit in this docs-only change (missing verb "use" before pay_for_offer_from_hrn at line 14576-14577). No bugs, security issues, or logic errors. No additional issues to report.

@ldk-reviews-bot ldk-reviews-bot requested a review from wpaulino April 3, 2026 11:27
@TheBlueMatt
Correctly refer to pay_for_offer_from_hrn in pay_for_offer docs
3902908 
If a `pay_for_offer` call comes in that was for an HRN, downstream
code should instead call `pay_for_offer_from_hrn`, not
`pay_for_offer`.
@TheBlueMatt TheBlueMatt force-pushed the 2026-04-drop-native-dns branch from fa4f1fc to 3902908 Compare April 3, 2026 11:46
vincenzopalazzo
vincenzopalazzo approved these changes Apr 3, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@vincenzopalazzo vincenzopalazzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ldk-reviews-bot
Copy link
Copy Markdown

ldk-reviews-bot commented Apr 6, 2026

🔔 1st Reminder

Hey @wpaulino! This PR has been waiting for your review.
Please take a look when you have a chance. If you're unable to review, please let us know so we can find another reviewer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wpaulino wpaulino Awaiting requested review from wpaulino

2 more reviewers

@ldk-claude-review-bot ldk-claude-review-bot ldk-claude-review-bot left review comments

@vincenzopalazzo vincenzopalazzo vincenzopalazzo approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@TheBlueMatt @ldk-reviews-bot @ldk-claude-review-bot @vincenzopalazzo