fix(deps): bump axios to 1.18.1 for Aikido CVEs (EXSC-728) - #2160
fix(deps): bump axios to 1.18.1 for Aikido CVEs (EXSC-728)#21600xDEnYO wants to merge 4 commits into
Conversation
Force transitive copies (Ledger/tronweb/matic/defender/uma) onto the patched line via overrides so Aikido critical CVEs clear on contracts. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Warning Review limit reached
Next review available in: 1 minute Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. WalkthroughChangesAxios version update
Estimated code review effort: 1 (Trivial) | ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Pull request was converted to draft
…ikido-critical-cves
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@package.json`:
- Around line 65-66: Update the direct axios dependency specification in
package.json to exactly match the existing axios override at 1.18.1, ensuring
npm accepts the direct dependency override. Then validate dependency resolution
with npm install --package-lock-only --ignore-scripts --dry-run.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 5295b074-0f81-4503-a625-6a33fe467e35
⛔ Files ignored due to path filters (1)
bun.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
package.json
…ikido-critical-cves
0xDEnYO
left a comment
There was a problem hiding this comment.
Re-triggering protect-critical-code — it only runs on pull_request_review and had not reported on the current head commit (branch was updated to pick up the injective targetEvmVersion fix).
npm rejects overrides that differ from a direct dependency's version spec (EOVERRIDE). Align dependencies.axios with overrides.axios. Co-authored-by: Cursor <cursoragent@cursor.com>
🔍 QA Review — EXSC-728 — Axios CVE Remediation (Bun Overrides)
SummaryPR #2160 correctly remediates the Aikido-flagged CVE-2026-40175 (and related axios high/critical findings) by pinning Acceptance Criteria Verification
FindingsNone. The fix is minimal and correct. Earlier concern resolved: A prior draft had a mismatch between Process ItemsNone required. This is a dependency-only change with no audit surface;
|
There was a problem hiding this comment.
✅ QA AI Approved (Run #30 — 2026-07-31). axios@1.18.1 pinned correctly in both dependencies and overrides; all 8 transitive vulnerable copies eliminated. No regressions.
Which Linear task belongs to this PR?
https://linear.app/lifi-linear/issue/EXSC-728/upgrade-axios-to-1181-for-aikido-critical-cves
Why did I implement it this way?
Aikido issue 17132073 (severity 99 / critical, 28 CVEs) flags
axiosin this repo. Recommendation: upgrade to ≥ 1.18.0 (or ≥ 1.15.0 for critical-only).Before: direct dep
^1.9.0resolved to1.11.0, while nested pins still pulled vulnerable copies (1.7.7Ledger,1.11.0tronweb,0.21.4matic/defender,0.24.0uma).Change:
^1.18.1overrides.axios = 1.18.1so every consumer resolves to the patched version (same pattern as thesockspin for EXSC-717)Prior Aikido AutoFix PR #1713 incorrectly overrode to
0.31.0(a downgrade) and was closed — this PR uses the version Aikido currently recommends.Checklist before requesting a review
Checklist for reviewer (DO NOT DEPLOY and contracts BEFORE CHECKING THIS!!!)