Use mapAccumulate

[Masynchin]

Did it in Github Edit, will wait for CI for correctness. I would also update deleteAt, but it requires mapAccumulateFilter, which I did implemented but not finished in in typelevel/cats#4561

[Masynchin]

@lenguyenthanh can you benchmark this changes when test pipeline becomes successful? I suppose it should be faster, because it doesn't use reverse, and, for List specialization of mapAccumulate, uses mutable variable for state rather then accumulator and uses map for transforming, rather then manual list construction (either :: with reverse or :+ which is O(n) (I suppose?))

[Masynchin]

I may also delete Some(_) in modifyAt, since it uses only Some(true) and false, but not Some(false)

[ornicar]

Nice! I requested a CI re-run and it passed

[lenguyenthanh]

@lenguyenthanh can you benchmark this changes when test pipeline becomes successful?

I don't think we have benchmark for this part of code base yet :( but I'll figure something out.

[lenguyenthanh]

I suppose it should be faster, because it doesn't use reverse, and, for List specialization of mapAccumulate, uses mutable variable for state rather then accumulator and uses map for transforming, rather then manual list construction (either :: with reverse or :+ which is O(n) (I suppose?))

after checking cats implementation, I believe this too (also a bit lazy to write benchmark for it)