✨(minor) Add AS5600 magnetic rotary encoder#36
Merged
Conversation
kammce
requested changes
May 21, 2026
Member
kammce
left a comment
kammce
left a comment
There was a problem hiding this comment.
Looking really good. With these changes we can merge this in.
kammce
changed the title
kammce
changed the title
kammce
requested changes
May 23, 2026
Member
kammce
left a comment
kammce
left a comment
There was a problem hiding this comment.
Looks great. We need a few more API doc changes and we should be ready to merge.
Member
Author
|
Deferring CI checks because they are old and need to be upgraded. See issue #38 |
kammce
approved these changes
May 24, 2026
Updated power mode enum values for clarity and added detailed explanation for angle hysteresis.
Updated comments for clarity and formatting consistency.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.