Conversation
The https://www.iausofa.org/current_C.html page no longer exists. Changing the default value of the `url` parameter in `_find_sofa_url_on_web_page()` to https://www.iausofa.org/current-software or https://www.iausofa.org/2023-10-11c both lead to a `ValueError`. There is no guarantee that the SOFA webpages do not change in the future, so updating `_find_sofa_url_on_web_page()` is not worthwhile. The simplest solution is to replace its single invocation with the new URL of the SOFA tarball.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The https://www.iausofa.org/current_C.html page no longer exists. Changing the default value of the
urlparameter in_find_sofa_url_on_web_page()to https://www.iausofa.org/current-software or https://www.iausofa.org/2023-10-11c both lead to aValueError. There is no guarantee that the SOFA webpages do not change in the future, so updating_find_sofa_url_on_web_page()is not worthwhile. The simplest solution is to replace its single invocation with the new URL of the SOFA tarball.I have verified that with my patch I can almost recreate the ERFA source files. The differences are in the copyright statement:
which is to be expected. Other than that the generated
t_erfa_c.cmisses a closing bracket added in liberfa/erfa@cb0e813 and there are some differences indat.cwhich seem to be related to leap seconds. The generated files do not includeerfaversion.c,Makefile.am,meson.buildand a few more files that all have "extra" in their name. None of those differences seem too surprising to me.