Remove the stray gitlink pointing at the repo itself - #67
Merged
Conversation
Commit d05d9ac added a gitlink (mode 160000) at `activerecord-clean-db-structure` pointing at an earlier commit of this same repository, with no matching .gitmodules entry. Released gems are unaffected, so this went unnoticed, but it breaks every git-sourced install. Bundler runs `git submodule foreach` after cloning, which aborts with "No url found for submodule path", so a Gemfile using `gem "activerecord-clean-db-structure", github: ...` cannot install at all. That also blocks the usual way of testing a pull request against a real app.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
mastercurrently carries a gitlink at the repository root:It points at commit
7c3625fof this same repository and has no matching.gitmodulesentry. It came in with d05d9ac, most likely an accidentalgit add.Gems installed from RubyGems are unaffected, which is why this has gone unnoticed — but it breaks every git-sourced install. Bundler runs
git submodule foreachafter cloning, which aborts with:Bundler retries and then fails the install outright, so
gem "activerecord-clean-db-structure", github: "lfittl/activerecord-clean-db-structure"cannot resolve today. That also blocks the usual way of testing a pull request against a real application, which is how I ran into it.Split out of #66 as requested — I'll rebase that branch to drop this commit once this one lands.