Expose structs: libraw_imgother_t and libraw_lensinfo_t#289
Conversation
letmaik
left a comment
There was a problem hiding this comment.
Thanks for the contribution, I think this is quite useful, especially if other libraries don't cover it. It definitely needs some tests, and I would change it to typed named tuples. Bonus points if you can extend the sphinx API docs as well.
|
I renamed fields. I also added 2 tests. But im unsure if they are correct. I don't really see the point of veryfing each field since its either fully correct or not. And even if there was a bug it would be due to libraw and not due to the rawpy
I would also like to expose class GPS(NamedTuple):
latitude: float
longitude: float
altitude: float | None
altitude_ref: int
timestamp: str | NoneAnd idk if u want the the wrapper to handle the conversion(and if yes, in |
|
Any news? |
|
Re For gps data, your proposed named tuple makes sense. The conversion needs to happen in the .pyx. |
|
I will be using You are right. There's indeed I am happy to merge if you are |
Per what i said in #287
I exposed imgother_t and lensinfo_t structs.
Its my first real PR to an open source project. And I have no expierience with c++ pyhon wrappers so i apologize if I did something wrong.
Im unsure whetever i should add tests for this.
And im unsure if i should update the docs/add examples.
Im looking forward to hear what i should change/update