refactor: img-cond->img_uncond#1594
Conversation
|
Alternatively I could just revert the name changes and just include the optimisations, but this naming makes more sense to me. |
|
I don’t think this PR should change the default behavior. |
|
@leejet I think the default img cfg scale should always be 1. I know it has been set to = txt-cfg for a while, but this is not right. As I shown in this comment: #929 (comment), or in your exemple, higher img cfg scale can cause issues at a higher degree than higher txt cfg. (apg can help handle it but that's besides the point) The results with edit models are changed from current Master, because there is a discrepency between the way kontext-like ref images and concat latents are handled with img cfg (forgot to mention that in the PR summary) Master:
PR:
|
|
I’ve set the default image CFG to |




Summary
Re-implement some changes that were dropped from #929
--img-cfg-scale 1Before this change the conditionning were:
cond: positive prompt, concat, kontext refsuncond: negative prompt, no concat, kontext refsimg_cond: negative prompt, concat, no kontext refsWith this PR, they become:
cond: positive prompt, concat, kontext refsuncond: negative prompt, concat, kontext refsimg_uncond: negative prompt, no concat, no kontext refsIn a way it's just swapping the roles of
uncondandimg_(un)condfor inpaint / unet edit models.Related Issue / Discussion
N/A
Additional Information
Checklist