fix: remove invalid alt attribute from button elements#7544
Open
inoovador wants to merge 1 commit intolayer5io:masterfrom
Open
fix: remove invalid alt attribute from button elements#7544inoovador wants to merge 1 commit intolayer5io:masterfrom
inoovador wants to merge 1 commit intolayer5io:masterfrom
Conversation
The alt attribute is only valid on <img>, <area>, and <input type="image"> elements. Several Button components had alt attributes which are invalid on <button> elements. The buttons already use aria-label and title for accessibility, so the alt attributes are unnecessary. Closes layer5io#7485 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Member
|
🚀 Preview for commit 931abc7 at: https://69c1744bcad5d1159f313435--layer5.netlify.app |
rishiraj38
reviewed
Mar 24, 2026
Member
rishiraj38
left a comment
rishiraj38
left a comment
There was a problem hiding this comment.
The DCO is failing. Please commit using git commit -s to pass it.
Siddhi-sahu
reviewed
Mar 25, 2026
Contributor
Siddhi-sahu
left a comment
Siddhi-sahu
left a comment
There was a problem hiding this comment.
👋@inoovador, please fix the DCO. Everything else looks good😊👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
altattribute from<Button>components in 4 filesaltattribute is only valid on<img>,<area>, and<input type="image">elements, not on<button>aria-labelandtitlefor accessibility, so thealtattributes were unnecessaryFiles changed:
src/sections/Products/index.js- Removedaltfrom 6 Button instancessrc/sections/Kanvas/kanvas-buttons.js- Removedaltfrom 2 Button instancessrc/sections/Solutions/solutions-buttons.js- Removedaltfrom 1 Button instancesrc/sections/General/Navigation/index.js- Removedaltfrom 1 commented-out Button instanceCloses #7485
🤖 Generated with Claude Code