Upgrade docsy to latest version#916
Conversation
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
✅ Deploy Preview for bejewelled-pegasus-b0ce81 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
I added this because after upgrading Docsy, it now uses td/_nav.scss for navbar styles.
Our old navbar styles (in _nav.scss) were not getting applied, so I imported them here to make sure they work again.
There was a problem hiding this comment.
Screen-Recording.mp4
There was a problem hiding this comment.
Also, instead of importing, we could directly move our _nav.scss into td/. That should also work — just checking if that approach is preferred? I didn’t change that for now.
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
|
@Sbragul26 Thank you for your contribution! Let's discuss this during the website call tomorrow at 5:30 PM IST | 7 AM CST Add it as an agenda item to the meeting minutes, if you would 🙂 |
Signed-off-by: Sbragul26 <sbragul26@gmail.com>
|
Thanks @Sbragul26 lgtm!! |
Notes for Reviewers
This PR fixes #895
Signed commits