Repository navigation
fix(lyrics): treat each LRC timestamp tag as its own line - #6
Closed
lawrence-millard wants to merge 1 commit into
Closed
lawrence-millard wants to merge 1 commit into
lawrence-millard wants to merge 1 commit into
Conversation
Providers emit [mm:ss][mm:ss]chorus. parseLrc kept only the last tag, so earlier chorus times never synced. Expand each leading tag into its own line and sort by startTime. Co-authored-by: Lawrence <lawrence-millard@users.noreply.github.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
Closed: Lawrence said no auto-PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
LRC from LRCLIB / Netease / Kugou often puts several times on one line:
parseLrcusedparseLrcTimestamp, which kept only the last tag (65.5s). The 20s chorus never became an active line, so letter-sync and auto-scroll jumped late.Fix
parseLrcTaggedLinewalks consecutive leading[mm:ss(.xxx)]tags, emits oneLyricLineper time, thenparseLrcsorts bystartTimeso a later tag on an earlier file line still sits in timeline order.How to verify (code-level; no device)
Python equivalent of the expander (same numbers the Swift helper uses):
On device: open lyrics for a track with repeated-chorus LRC; the line must highlight at each listed time, not only the last.
No Last.fm/Discord RPC.