fix(search): ignore completed results from an older submit

[lawrence-millard]

Problem

SearchViewModel.submit started an unowned Task for each query. SearchService.search cancels the previous InnerTube task, but if request A already completed before B started, fetchResults(A) still assigned results / phase after B’s UI update.

Repro at the call level: submit “hello”, then immediately submit “hello world”. A can finish parse and write sections for “hello” after “hello world” is the submitted query.

Fix

• Track resultsTask and cancel it in cancelTasks() (new submit and idle clear).
• After await, apply results or failure only if submittedQuery == query and the task was not cancelled.

How to verify

1. Submit a slow/broad query, then immediately submit a different query.
2. The list must show only the last submitted query’s sections (or its error), never the first query after the second has been submitted.

Device search not run here. No Last.fm/Discord RPC.

  

[coderabbitai]

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

• Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[lawrence-millard]

Closed: Lawrence said no auto-PRs.