Repository navigation
fix(artwork): drop late thumbnail fetches after skip - #3
Closed
lawrence-millard wants to merge 1 commit into
Closed
lawrence-millard wants to merge 1 commit into
lawrence-millard wants to merge 1 commit into
Conversation
loadThumbnail sets lastLoadedVideoId then fetches asynchronously. Skipping A→B started both fetches; if A finished last it replaced B's art, lock-screen artwork, and dominant colors. Co-authored-by: Lawrence <lawrence-millard@users.noreply.github.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Owner
Author
|
Closed: Lawrence said no auto-PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
NowPlaying.loadThumbnailrecordslastLoadedVideoIdand then fetches via Nuke. Skip A → B starts two loads. If A’s image returns after B’s, it overwrites:MPMediaItemArtworklastLoadedVideoIdonly skipped a new load for the same id; it did not gate apply.Fix
Apply (or placeholder-on-error) only when
lastLoadedVideoIdstill matches the request.How to verify
videoId’s image is applied.No device build in this environment. No Last.fm/Discord RPC.