remove unecessary dependency on 'network' module from 'clevis-pin-tpm1' dracut module

[itspngu]

Fixes #571

[oldium]

The tpm1 pin (tcsd daemon) requires a working localhost connection, i.e. lo network interface setup, which is not always the case. It might be for the systemd path, but not for the non-systemd one. The easiest universal way of telling we need a working networking setup is a network dependency.

I can have a look at this and check on which setups this is needed. This needs to be tested in all supported scenarios.

[oldium]

The minimal working configuration taking into account systemd is the following:

Suggested change

	echo clevis
	local __depends="clevis"
	if ! dracut_module_included "systemd"; then
	__depends=$(printf '%s network' "${__depends}")
	fi
	echo "${__depends}"

[sarroutbi]

/packit test

[oldium]

Please do not merge, this will break TPM1 pin on non-Systemd boot. I am thinking about simply checking if lo is up on non-Systemd boot and set it up - instead of having the full network dependency. Systemd is doing this automatically.

[sarroutbi]

Please do not merge, this will break TPM1 pin on non-Systemd boot. I am thinking about simply checking if lo is up on non-Systemd boot and set it up - instead of having the full network dependency. Systemd is doing this automatically.

Maybe you can convert it to Draft for us to be aware of it not being completed yet

[oldium]

Maybe you can convert it to Draft for us to be aware of it not being completed yet

I am not the author of the change; I cannot do anything about it. I spotted the topic and made a review - there is 1 requested change from me to make it non-systemd-only. But a better solution is as I said above.

[sarroutbi]

/packit retest-failed

[oldium]

I have time this weekend, so I will prepare a solution completely without the network dependency. Stay tuned.

[oldium]

Fix updated in #579 - ensure the /etc/hosts is created when not copied otherwise.

[sarroutbi]

@itspngu : May I ask you to close this PR and centralize the change in #579 ?

[sarroutbi]

/packit retest-failed