Repository navigation
fix(web): adopt upstream composer caret stops - #312
Merged
lastobelus merged 2 commits intoOct 7, 2026
Merged
Conversation
Owner
Author
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
lastobelus
marked this pull request as ready for review
October 7, 2026 00:39
…g#13217) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com> (cherry picked from commit d0dc458) Carry-Group: upstream-bugfixes Carry-Upstream: pingdotgg#13217 head 42ea6ff Carry-Observation: Import the merged upstream squash d0dc458 ahead of nightly adoption.
Use upstream's two caret stops as the single formatting boundary policy. Remove the competing plugin and retain paste, cut, history, and sustained formatting coverage under the upstream navigation semantics. Carry-Group: upstream-bugfixes Carry-Upstream: pingdotgg#13217 head 42ea6ff Carry-Supersedes: pingdotgg#13518 head cc1d991 Carry-Supersedes: #295 Carry-Observation: Upstream closed 13518 in favor of 13217. Remove the old marks plugin so it cannot fight the two-stop policy; preserve this removal when the nightly absorbs 13217.
lastobelus
force-pushed
the
port/upstream/pr-13217-composer-caret-stops
branch
from
October 7, 2026 00:49
8491b68 to
a83340c
Compare
Owner
Author
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Styled text at a composer boundary should offer both plain and formatted typing. Upstream closed pingdotgg#13518 because pingdotgg#13217 provides that behavior with two visible caret stops; carrying both implementations would make their stored-mark policies compete.
Import the merged upstream change and remove LastCode's superseded typing-marks extension. Paste, cut, undo/redo, and sustained formatting tests now follow the upstream two-stop behavior.
42ea6ff617128871b9fcd975811caae91f10cae2.cherry-pick -xof upstream's merged squashd0dc45885c1441da5bd46dcf13124d94ed728b0a; clean application, followed by removal of the extension from LastCode PR fix(web): escape formatting at composer boundaries #295 / upstream fix(web): escape formatting at composer boundaries pingdotgg/t3code#13518.v0.0.46-nightly.20261005.2702does not include fix(web): type in front of bold that starts a composer line pingdotgg/t3code#13217. Carry metadata records both the upstream source and the superseded plugin so future nightly replay keeps the removal.Integrated verification passed in the isolated web client through T3 Browser (1280×800 capture, 1169×731 CSS viewport). The same editor setup and native ArrowLeft + literal typing produced
**Note: bold**on the LastCode base andNote: **bold**on this branch. Paste/cut used synthetic clipboard events through the real editor; native ArrowRight, Cmd+Z / Cmd+Shift+Z, and sustained Cmd+I typing passed. The serialized draft persisted correctly. Fixture setup used editor commands; no provider turn ran.Recordings: before, after.
Imported and adapted by GPT-6-Astra through Codex in T3 Code; delivery and verification by GPT-6.1-Sol (xhigh) through Codex in T3 Code.