✨ Implement LaserFrame.__contains__() with DataFrame-style property/column membership - #422
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds DataFrame-like column membership semantics to LaserFrame via a new __contains__ implementation, enabling safe checks like "age" in lf for properties and selected instance attributes.
Changes:
- Implement
LaserFrame.__contains__to returnTruefor registered property names and non-underscored instance attributes, andFalsefor non-strings and underscored/internal instance attributes. - Add a new test suite covering
inbehavior for scalar/vector/array properties, kwargs-set attributes, unknown names, non-string items, and class-level methods/properties. - Document the new membership semantics in
CHANGELOG.rst.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/laser/core/laserframe.py |
Adds __contains__ to provide column-style membership checks against _properties and non-underscored instance attributes. |
tests/test_laserframe.py |
Adds new tests pinning the intended __contains__ contract and preventing regression to the prior super().__contains__ error. |
CHANGELOG.rst |
Describes the new LaserFrame.__contains__ semantics and their intent for callers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
clorton
force-pushed
the
property-in-laserframe
branch
from
June 24, 2026 20:16
4ecc72a to
08c0ca5
Compare
clorton
changed the title
clorton
changed the title
clorton
force-pushed
the
property-in-laserframe
branch
from
June 25, 2026 20:51
08c0ca5 to
1334156
Compare
jonathanhhb
reviewed
Jun 27, 2026
| return self._count | ||
|
|
||
| def __contains__(self, item) -> bool: | ||
| # Column-style membership: True for any name LaserFrame's documented access |
Collaborator
There was a problem hiding this comment.
GPT thought the doc string could be tweaked to emphasize the most surprising element of the design (allowing preceding underscores to be treated the regular attributes). I of course understand why we're doing this but GPT thought it's genuinely a little surprising to a python-trained mind.
For your consideration. Otherwise all makes sense.
jonathanhhb
requested changes
Jun 27, 2026
jonathanhhb
left a comment
jonathanhhb
left a comment
Collaborator
There was a problem hiding this comment.
"Request change" is more "consider slight doc string change". Not required.
membership Adds a `__contains__` method that returns `True` for property names and non-underscored kwargs-set attributes, and `False` for underscored backing arrays, internal state, methods, class-level descriptors, and non-string items. Includes ten new tests covering the full contract.
clorton
force-pushed
the
property-in-laserframe
branch
from
June 29, 2026 23:23
1334156 to
b59b77b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale
Some "syntactic sugar" that is useful for validation ("my component needs this property to exist on the LaserFrame to work correctly") or customization ("if no one else has added this property, then I will so my component can function correctly").
Adds a
__contains__method that returnsTruefor property names and non-underscored kwargs-set attributes, andFalsefor underscored backingarrays, internal state, methods, class-level descriptors, and non-string items. Includes ten new tests covering the full contract.
Fixes #275