Fix misaligned error pointer for full-width characters - #1627
Open
yashasvi-srivastava21 wants to merge 3 commits into
Open
Fix misaligned error pointer for full-width characters#1627yashasvi-srivastava21 wants to merge 3 commits into
yashasvi-srivastava21 wants to merge 3 commits into
Conversation
Member
|
This PR already tried solving it, but didn't finish: #1593 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1530
get_context()pads the^error pointer using one regular spaceper preceding character. This assumes every character has the same
visual width, which breaks down for full-width (CJK) characters,
causing the pointer to land on the wrong column.
This PR adds a
_padding_for()helper that checks each character'sUnicode east-asian-width property and substitutes a full-width space
(U+3000) for wide/full-width characters, keeping the pointer aligned
regardless of character width.