Fix Python comprehension filters after each for clause - #1623
Open
amkdown-max wants to merge 2 commits into
Open
Fix Python comprehension filters after each for clause#1623amkdown-max wants to merge 2 commits into
amkdown-max wants to merge 2 commits into
Conversation
amkdown-max
marked this pull request as ready for review
July 19, 2026 07:21
Member
|
Looks good! Just one nit, I prefer - It's more organized and easier to process. What do you think? |
Author
|
Agreed — this is clearer and keeps the rule easier to process. Updated in 085eba1. The full test suite (1,311 tests), mypy, and all pre-commit hooks pass. Thanks! |
Author
MegaIng
approved these changes
Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
comp_ifclauses to eachcomp_forforclausesWhy
Python permits every comprehension
forclause to have its own sequence ofiffilters. Lark's grammar instead placed one optional filter after the entirecomp_forssequence, so valid expressions such as:failed when the parser reached the second
for.This change mirrors CPython's
for_if_clausestructure by keeping each clause's filters with that clause.Fixes #1525.
Validation
python3 -m tests TestPythonParserpython3 -m tests(1311tests passed,174skipped)pre-commit run --all-files --show-diff-on-failurelark/andtests/