[13.x] Fix nullable return types on the route binding registrar - #61124
Merged
taylorotwell merged 1 commit intoAug 10, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Illuminate\Contracts\Routing\BindingRegistrar::getBindingCallback()documents@return \Closure, but its only implementation returnsnullwhenever the given key has no registered binder:Broadcaster::binder()has the same gap. It documents@return \Illuminate\Contracts\Routing\BindingRegistrar, but assignsnullwhen no registrar is bound in the container:Because both docblocks claim non-null, static analysis reports the framework's own null handling as dead code. Running PHPStan over the contract, the router and the broadcaster (level 6,
checkPhpDocMethodSignatures: true):Those are the
if ($binder && $binder->getBindingCallback($key))guard and thereturn $value;fallback inresolveExplicitBindingIfPossible(), plus the lazy initialization inbinder(). Adding|nullto the three docblocks clears all four.The
Routefacade already documents the real type:@method static \Closure|null getBindingCallback(string $key).Docblocks only, no behavior change.